Fixes sign in method caching issues #1469 and #1262 #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undefobj
approved these changes
Mar 25, 2020
|
Thanks @undefobj - I thought about that but at this point don't have the time commitment to write that so feel like it's better to at least stop the bleeding for now and also we're hoping to replace AWSMobileClient anyway |
jamesonwilliams
approved these changes
Mar 25, 2020
|
Hello @TrekSoft, it passed a few days from release 2.16.10 version and there are change logs but the library is not uploaded on maven repo. |
|
Hey @karmaobserver - sorry for that - investigating how it missed getting uploaded to maven. |
|
Thank you very much, it's up now. |
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SIGN_IN_MODE is only set when the user signs in with HostedUI or OAuth leading to a failure in retrieving tokens if the user afterwards ever tries to sign in with UserPools or Federated Identities.
This ensures that the sign in mode is switched when those methods are used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.